Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phar or not Phar? #1565

Closed
niconoe- opened this issue Sep 6, 2021 · 4 comments
Closed

Phar or not Phar? #1565

niconoe- opened this issue Sep 6, 2021 · 4 comments
Assignees
Labels

Comments

@niconoe-
Copy link
Contributor

niconoe- commented Sep 6, 2021

Hi all!

I just have a question regarding the releases here: https://github.com/infection/infection/releases.

Sometimes, there are phar files in assets, (0.24, 0.23, ...) but sometimes there's not (0.25, 0.22, ...).

What is the rule about it? I'm asking as I'm creating a Dockerfile downloading this phar to use Infection in several projects though different versions, but if the phar is missing, of course I can't rely on it.

I don't mind of always having a phar or never have it, I just need to have somethng to trust to build my Dockerfile images actually, so I need some consistent process and being in this situation is not consistent.

Thanks a lot!
Have a nice day!

@maks-rafalko
Copy link
Member

Hello, thanks for your question and concerns, totally makes sense. Right now we have an issue with generating PHAR file, this is what I'm going to fix, but with limited time and resources.

This happened because of #1508, and once we add generating and testing PHAR back to our pipeline, I think we will be sure that every release will have attached file immediately, without a delay.

For 0.25, I will deploy the PHAR as soon as the issue is fixed. Sorry about that.

@maks-rafalko maks-rafalko self-assigned this Sep 6, 2021
@maks-rafalko
Copy link
Member

Uploaded PHAR files

Please report any issues, thank you.

@niconoe-
Copy link
Contributor Author

niconoe- commented Sep 6, 2021

Ok, thank you very much for your answer and for taking the time to upload the PHAR as well, it will definitly help me for the version 0.25.0.

I hope you'll find some help regarding #1508 as it looks like really hard to fix, since because of GitHub Actions not performing E2E test, you're blocked, if I understand correctly.

I'll give you feedback about how 0.25.0 is working with the PHAR in few hours, when I'll get back to work.

Thanks again.
Regards,

@niconoe-
Copy link
Contributor Author

niconoe- commented Sep 7, 2021

0.25.0 tested and working like a charm! Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants