TestLocator returns non-unique tests, but Mutation didn't know that #1310
+305
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanmai
force-pushed
the
pr/2020-08/timeout-skipped
branch
from
d70253f
to
f55226a
Compare
Closed
sanmai
changed the title
Fixes infection#1304 TestLocator returns non-unique tests, and JUnitTestCaseSorter works around that; we have to do that too.
sanmai
force-pushed
the
pr/2020-08/timeout-skipped
branch
from
dea97dc
to
32274f8
Compare
maks-rafalko
approved these changes
Aug 25, 2020
There was a problem hiding this comment.
Thank you @sanmai for working on this issue.
As I understand, Travis' failures are due to min MSI
|
Would you be able to port to |
|
Sure! |
sanmai
added a commit
to sanmai/infection
that referenced
this pull request
Aug 25, 2020
…nfection#1310) * TestLocator returns non-unique tests, but Mutation didn't know that Fixes infection#1304 TestLocator returns non-unique tests, and JUnitTestCaseSorter works around that; we have to do that too. * Extend test case to include summation * Timings are per test suite, not per test, therefore we have to unique by test suite name * Fix PHPStan warning * Extract adding logic into JUnitTestCaseTimeAdder
|
Do you think you can do |
maks-rafalko
pushed a commit
that referenced
this pull request
Aug 25, 2020
…1310) * TestLocator returns non-unique tests, but Mutation didn't know that Fixes #1304 TestLocator returns non-unique tests, and JUnitTestCaseSorter works around that; we have to do that too. * Extend test case to include summation * Timings are per test suite, not per test, therefore we have to unique by test suite name * Fix PHPStan warning * Extract adding logic into JUnitTestCaseTimeAdder
|
Done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestLocator returns non-unique tests, and JUnitTestCaseSorter works around that; we have to do that in Mutation too.
This PR:
Should not be a problem to port this to master branch.
(AppVeyor failures were fixed by #1302 in master)