Remove PHPStan's baseline for src (#1593)

infection · Oct 13, 2021 · ef4ddca · ef4ddca
1 parent d86ddd6
commit ef4ddca
Show file tree

Hide file tree

Showing 8 changed files with 18 additions and 224 deletions.
diff --git a/devTools/phpstan-src-baseline.neon b/devTools/phpstan-src-baseline.neon
diff --git a/devTools/phpstan-src.neon b/devTools/phpstan-src.neon
@@ -1,13 +1,16 @@
 includes:
     - ../vendor/phpstan/phpstan/conf/bleedingEdge.neon
-    - phpstan-src-baseline.neon
 
 parameters:
     tmpDir: ../build/cache/phpstan-src
     inferPrivatePropertyTypeFromConstructor: true
     ignoreErrors:
         - '#.* value type specified in iterable type Symfony\\Component\\Process\\Process#'
         - '#generic class ReflectionClass (but )?does not specify its types#'
+        - '#^Call to static method Webmozart\\Assert\\[a-zA-Z]+::[a-zA-Z]+\(\) with .* will always evaluate to true\.$#'
+        - '#^Parameter \#\d+ \$.+ \(.+\) of method .+ should be contravariant with parameter \$.+ \(.+\) of method .+$#'
+        - '#^Short ternary operator is not allowed\. Use null coalesce operator if applicable or consider using long ternary\.$#'
+        - '#^Variable (method|property) (access|call) #'
         -
             path: '../src/Mutator/Number/DecrementInteger.php'
             message: '#Casting to int .* already int#'
@@ -28,6 +31,10 @@ parameters:
             path: '../src/TestFramework/Coverage/XmlReport/SourceFileInfoProvider.php'
             message: '#Function realpath is unsafe to use\.#'
             count: 1
+        -
+            path: ../src/TestFramework/Factory.php
+            message: "#^Parameter \\#1 \\$it of function iterator_to_array expects Traversable, iterable\\<Infection\\\\TestFramework\\\\Coverage\\\\Trace\\|SplFileInfo\\> given\\.$#"
+            count: 1
         -
             path: '../src/Container.php'
             message: '#^Method Infection\\Container::get.*\(\) should return .* but returns object\.$#'
@@ -38,3 +45,4 @@ parameters:
     level: max
     paths:
         - ../src
+    treatPhpDocTypesAsCertain: false
diff --git a/src/Logger/PerMutatorLogger.php b/src/Logger/PerMutatorLogger.php
@@ -146,7 +146,7 @@ private static function calculateColumnSizes(array $table): array
 
         foreach ($table as $row) {
             foreach ($row as $columnNumber => $cell) {
-                $sizes[$columnNumber] = (int) max($sizes[$columnNumber], strlen($cell));
+                $sizes[$columnNumber] = max($sizes[$columnNumber], strlen($cell));
             }
         }
 
@@ -179,11 +179,11 @@ private static function createSeparatorRow(array $columnSizes): string
      */
     private function createMetricsPerMutators(): array
     {
-        $executionResults = $this->resultsCollector->getAllExecutionResults();
+        $allExecutionResults = $this->resultsCollector->getAllExecutionResults();
 
         $processPerMutator = [];
 
-        foreach ($executionResults as $executionResult) {
+        foreach ($allExecutionResults as $executionResult) {
             $mutatorName = $executionResult->getMutatorName();
             $processPerMutator[$mutatorName][] = $executionResult;
         }

diff --git a/src/Logger/TextFileLogger.php b/src/Logger/TextFileLogger.php
@@ -72,6 +72,8 @@ public function getLogLines(): array
     {
         $separateSections = false;
 
+        $logs = [];
+
         $logs[] = $this->getResultsLine(
             $this->resultsCollector->getEscapedExecutionResults(),
             'Escaped',

diff --git a/src/Mutator/MutatorFactory.php b/src/Mutator/MutatorFactory.php
@@ -100,7 +100,7 @@ public static function getMutatorNameForClassName(string $className): string
     {
         $parts = explode('\\', $className);
 
-        return (string) end($parts);
+        return end($parts);
     }
 
     /**

diff --git a/src/TestFramework/Coverage/JUnit/TestLocationBucketSorter.php b/src/TestFramework/Coverage/JUnit/TestLocationBucketSorter.php
@@ -78,7 +78,7 @@ public static function bucketSort(array $uniqueTestLocations): iterable
             // This is a very hot path. Factoring here another method just to test this math may not be as good idea.
 
             // Quick drop off lower bits, reducing precision to 8th of a second
-            $msTime = $location->getExecutionTime() * 1024 >> 7; // * 1024 / 128
+            $msTime = ($location->getExecutionTime() ?? 0) * 1024 >> 7; // * 1024 / 128
 
             // For anything above 4 seconds reduce precision to 4 seconds
             if ($msTime > 32) {

diff --git a/src/TestFramework/PhpUnit/Adapter/PestAdapterFactory.php b/src/TestFramework/PhpUnit/Adapter/PestAdapterFactory.php
@@ -57,6 +57,7 @@
 final class PestAdapterFactory implements TestFrameworkAdapterFactory
 {
     /**
+     * @param string[] $sourceDirectories
      * @param list<string> $filteredSourceFilesToMutate
      */
     public static function create(

diff --git a/src/TestFramework/TestFrameworkExtraOptionsFilter.php b/src/TestFramework/TestFrameworkExtraOptionsFilter.php
@@ -59,6 +59,6 @@ public function filterForMutantProcess(string $actualExtraOptions, array $initia
             Assert::notNull($actualExtraOptions);
         }
 
-        return (string) preg_replace('/\s+/', ' ', trim($actualExtraOptions));
+        return preg_replace('/\s+/', ' ', trim($actualExtraOptions));
     }
 }