Skip to content

Commit

Permalink
Fix #1408
Browse files Browse the repository at this point in the history
  • Loading branch information
sanmai committed Nov 2, 2020
1 parent a158689 commit de3d6de
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 12 deletions.
20 changes: 14 additions & 6 deletions src/Mutator/MutatorResolver.php
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,14 @@ private static function resolveSettings($settings, array $globalSettings)
return false;
}

if (count($globalSettings) === 0) {
return (array) $settings;
}

if ($settings === true) {
return $globalSettings;
}

if (count($globalSettings) === 0) {
return (array) $settings;
}

return array_merge_recursive($globalSettings, (array) $settings);
}

Expand Down Expand Up @@ -219,8 +219,16 @@ private static function registerFromClass(
): void {
if ($settings === false) {
unset($mutators[$mutatorClassName]);
} else {
$mutators[$mutatorClassName] = (array) $settings;

return;
}

if ($settings === true || $settings === []) {
$mutators[$mutatorClassName] = $mutators[$mutatorClassName] ?? [];

return;
}

$mutators[$mutatorClassName] = $settings;
}
}
6 changes: 0 additions & 6 deletions tests/phpunit/Mutator/MutatorResolverTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -353,13 +353,10 @@ public function test_it_works_wrong(): void
],
],
IncrementInteger::class => [
true,
],
OneZeroFloat::class => [
true,
],
OneZeroInteger::class => [
true,
],
],
$resolvedMutators
Expand All @@ -385,13 +382,10 @@ public function test_it_works_right(): void
],
],
IncrementInteger::class => [
true,
],
OneZeroFloat::class => [
true,
],
OneZeroInteger::class => [
true,
],
],
$resolvedMutators
Expand Down

0 comments on commit de3d6de

Please sign in to comment.