Use constants instead of hardcoded values for PHP_INT_(MAX|MIN) to ru…

…n tests successfully on 32/64-bit systems (#1490)
infection · Feb 23, 2021 · d7dcd4f · d7dcd4f
1 parent c52cdc8
commit d7dcd4f
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 6 deletions.
diff --git a/tests/phpunit/Mutator/Number/DecrementIntegerTest.php b/tests/phpunit/Mutator/Number/DecrementIntegerTest.php
@@ -36,6 +36,7 @@
 namespace Infection\Tests\Mutator\Number;
 
 use Infection\Tests\Mutator\BaseMutatorTestCase;
+use const PHP_INT_MIN;
 
 final class DecrementIntegerTest extends BaseMutatorTestCase
 {
@@ -507,11 +508,13 @@ public function mutationsProvider(): iterable
 PHP
         ];
 
+        $minInt = PHP_INT_MIN;
+
         yield 'It does not decrement min int' => [
-            <<<'PHP'
+            <<<"PHP"
 <?php
 
-if ($a === -9223372036854775808) {
+if (1 === {$minInt}) {
     echo 'bar';
 }
 PHP

diff --git a/tests/phpunit/Mutator/Number/IncrementIntegerTest.php b/tests/phpunit/Mutator/Number/IncrementIntegerTest.php
@@ -36,6 +36,7 @@
 namespace Infection\Tests\Mutator\Number;
 
 use Infection\Tests\Mutator\BaseMutatorTestCase;
+use const PHP_INT_MAX;
 
 final class IncrementIntegerTest extends BaseMutatorTestCase
 {
@@ -242,17 +243,19 @@ public function mutationsProvider(): iterable
 PHP
         ];
 
+        $maxInt = PHP_INT_MAX;
+
         yield 'It does not increment max int' => [
-            <<<'PHP'
+            <<<"PHP"
 <?php
 
-random_int(10000000, 9223372036854775807);
+random_int(10000000, {$maxInt});
 PHP
             ,
-            <<<'PHP'
+            <<<"PHP"
 <?php
 
-random_int(10000001, 9223372036854775807);
+random_int(10000001, {$maxInt});
 PHP
         ];
     }