Ensure mutated code is always valid (#301)

* Ensure mutated code is always valid * Use piping instead of creating a file for `php -l` linting commandline
infection · Apr 12, 2018 · b0a34c2 · b0a34c2
1 parent 663f6a5
commit b0a34c2
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 3 deletions.
diff --git a/tests/Mutator/AbstractMutatorTestCase.php b/tests/Mutator/AbstractMutatorTestCase.php
@@ -38,6 +38,7 @@ public function doTest(string $inputCode, string $expectedCode = null)
         $realMutatedCode = $this->mutate($inputCode);
         if ($expectedCode !== null) {
             $this->assertSame($expectedCode, $realMutatedCode);
+            $this->assertSyntaxIsValid($realMutatedCode);
         } else {
             $this->assertSame($inputCode, $realMutatedCode);
         }
@@ -81,4 +82,18 @@ protected function mutate(string $code)
 
         return $prettyPrinter->prettyPrintFile($mutatedNodes);
     }
+
+    private function assertSyntaxIsValid(string $realMutatedCode)
+    {
+        exec(sprintf('echo %s | php -l', escapeshellarg($realMutatedCode)), $output, $returnCode);
+
+        $this->assertSame(
+            0,
+            $returnCode,
+            sprintf(
+                'Mutator %s produces invalid code',
+                $this->getMutator()::getName()
+            )
+        );
+    }
 }
diff --git a/tests/Mutator/Boolean/Yield_Test.php b/tests/Mutator/Boolean/Yield_Test.php
@@ -27,13 +27,19 @@ public function provideMutationCases(): \Generator
             <<<'PHP'
 <?php
 
-(yield $a => $b);
+function test()
+{
+    (yield $a => $b);
+}
 PHP
             ,
             <<<'PHP'
 <?php
 
-(yield $a > $b);
+function test()
+{
+    (yield $a > $b);
+}
 PHP
             ,
         ];
@@ -42,7 +48,10 @@ public function provideMutationCases(): \Generator
             <<<'PHP'
 <?php
 
-(yield $b);
+function test()
+{
+    (yield $b);
+}
 PHP
             ,
         ];