PhpProcess: Reset $_ENV if it is in use (#693)

* PhpProcess: Reset $_ENV if it is in use

As of 1.3.2 xdebug-handler won't update $_ENV if it is in use.
But Symfony's Process will happily import everything from $_ENV,
hence we need to reset it just as xdebug-handler does.

* Add missing phpunit.xml

* Update PhpProcess.php

src/Console/Util/PhpProcess.php

@@ -63,7 +63,23 @@ public function start(callable $callback = null, array $env = null): void
         $phpConfig = new PhpConfig();
 
         $phpConfig->useOriginal();
+
+        // As of 1.3.2 xdebug-handler won't update $_ENV if it is in use.
+        // But Symfony's Process will happily import everything from $_ENV,
+        // hence we need to reset it just as xdebug-handler does
+        $updateEnv = false !== stripos((string) ini_get('variables_order'), 'E');
+
+        if ($updateEnv) {
+            unset($_ENV['PHPRC']);
+            unset($_ENV['PHP_INI_SCAN_DIR']);
+        }
+
         parent::start($callback, $env ?? []);
         $phpConfig->usePersistent();
+
+        if ($updateEnv) {
+            $_ENV['PHPRC'] = $_SERVER['PHPRC'];
+            $_ENV['PHP_INI_SCAN_DIR'] = $_SERVER['PHP_INI_SCAN_DIR'];
+        }
     }
 }

tests/Fixtures/e2e/Variables_Order_EGPCS/README.md

@@ -0,0 +1,7 @@
+# Ensure Infection runs with non-empty `$_ENV`
+
+When `variables_order` set to constain an `E`, Infection should just work.
+
+https://github.com/infection/infection/issues/692
+
+https://github.com/infection/infection/pull/693

tests/Fixtures/e2e/Variables_Order_EGPCS/composer.json

@@ -0,0 +1,15 @@
+{
+    "require-dev": {
+        "phpunit/phpunit": "^7.5"
+    },
+    "autoload": {
+        "psr-4": {
+            "Variables_Order_EGPCS\\": "src/"
+        }
+    },
+    "autoload-dev": {
+        "psr-4": {
+            "Variables_Order_EGPCS\\Test\\": "tests/"
+        }
+    }
+}

tests/Fixtures/e2e/Variables_Order_EGPCS/expected-output.txt

@@ -0,0 +1,6 @@
+Total: 1
+Killed: 1
+Errored: 0
+Escaped: 0
+Timed Out: 0
+Not Covered: 0

tests/Fixtures/e2e/Variables_Order_EGPCS/infection.json

@@ -0,0 +1,12 @@
+{
+    "timeout": 25,
+    "source": {
+        "directories": [
+            "src"
+        ]
+    },
+    "logs": {
+        "summary": "infection.log"
+    },
+    "tmpDir": "."
+}

tests/Fixtures/e2e/Variables_Order_EGPCS/phpunit.xml.dist

@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+         xsi:noNamespaceSchemaLocation="./vendor/phpunit/phpunit/phpunit.xsd"
+         bootstrap="./vendor/autoload.php"
+         colors="true"
+>
+    <testsuites>
+        <testsuite name="Test Suite">
+            <directory>./tests/</directory>
+        </testsuite>
+    </testsuites>
+
+    <filter>
+        <whitelist>
+            <directory>./src/</directory>
+        </whitelist>
+    </filter>
+</phpunit>

tests/Fixtures/e2e/Variables_Order_EGPCS/run_tests.bash

@@ -0,0 +1,14 @@
+#!/usr/bin/env bash
+
+readonly INFECTION=../../../../bin/infection
+
+set -e pipefail
+
+if [ "$PHPDBG" = "1" ]
+then
+    phpdbg -d variables_order=EGPCS -qrr $INFECTION
+else
+    php -d variables_order=EGPCS $INFECTION
+fi
+
+diff -w expected-output.txt infection.log

tests/Fixtures/e2e/Variables_Order_EGPCS/src/SourceClass.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace Variables_Order_EGPCS;
+
+class SourceClass
+{
+    public function hello(): string
+    {
+        return 'hello';
+    }
+}

tests/Fixtures/e2e/Variables_Order_EGPCS/tests/SourceClassTest.php

@@ -0,0 +1,15 @@
+<?php
+
+namespace Variables_Order_EGPCS\Test;
+
+use Variables_Order_EGPCS\SourceClass;
+use PHPUnit\Framework\TestCase;
+
+class SourceClassTest extends TestCase
+{
+    public function test_hello()
+    {
+        $sourceClass = new SourceClass();
+        $this->assertSame('hello', $sourceClass->hello());
+    }
+}