-
-
Notifications
You must be signed in to change notification settings - Fork 155
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
4 changed files
with
29 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
# Inheritdoc usage [(#860)](https://github.com/infection/infection/issues/860) | ||
|
||
### Decision | ||
|
||
Do not use `@inheritdoc` tags or any of its variants. | ||
|
||
|
||
###Status | ||
|
||
Accepted | ||
|
||
|
||
### Context | ||
|
||
Using `@inheritdoc` was done inconsistently across the codebase so the decision of whether we use it | ||
systematically or remove it systematically had to be done. | ||
|
||
A number of points: | ||
|
||
- [PHPDoc](https://docs.phpdoc.org/guides/inheritance.html) provides inheritance of the docblocks | ||
by default when appropriate | ||
- Static analysers such as PHPStan or Psalm can do without at the time of writting | ||
|
||
Also it has a very limited value. | ||
|
||
|
||
### Consequences | ||
|
||
`@inheritdoc` tags and its variants must be removed when submitting pull requests. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters