Import native functions, use PathUtils instead of custom functions, f…

…ix escaped mutant

.github/workflows/mt-annotations.yaml

@@ -1,7 +1,7 @@
 # yamllint disable rule:line-length
 # yamllint disable rule:braces
 
-name: Infection
+name: Autoreview
 
 on:
     pull_request:

src/Logger/GitHub/GitDiffFileProvider.php

@@ -35,7 +35,9 @@
 
 namespace Infection\Logger\GitHub;
 
+use function escapeshellarg;
 use function Safe\sprintf;
+use function shell_exec;
 
 /**
  * @final

src/Logger/GitHubAnnotationsLogger.php

@@ -37,6 +37,8 @@
 
 use Infection\Metrics\MetricsCalculator;
 use function Safe\getcwd;
+use function str_replace;
+use Webmozart\PathUtil\Path;
 
 /**
  * @internal
@@ -57,7 +59,7 @@ public function getLogLines(): array
 
         foreach ($this->metricsCalculator->getEscapedExecutionResults() as $escapedExecutionResult) {
             $error = [
-                'line' => (string) $escapedExecutionResult->getOriginalStartingLine(),
+                'line' => $escapedExecutionResult->getOriginalStartingLine(),
                 'message' => <<<"TEXT"
 Escaped Mutant:
 
@@ -67,28 +69,23 @@ public function getLogLines(): array
             ];
 
             $lines[] = $this->buildAnnotation(
-                $this->relativePath($currentWorkingDirectory, $escapedExecutionResult->getOriginalFilePath()),
-                $error
+                Path::makeRelative($escapedExecutionResult->getOriginalFilePath(), $currentWorkingDirectory),
+                $error,
             );
         }
 
         return $lines;
     }
 
     /**
-     * @param array{line: string, message: string} $error
+     * @param array{line: int, message: string} $error
      */
     private function buildAnnotation(string $filePath, array $error): string
     {
-        // newlines need to be encoded
+        // new lines need to be encoded
         // see https://github.com/actions/starter-workflows/issues/68#issuecomment-581479448
         $message = str_replace("\n", '%0A', $error['message']);
 
         return "::warning file={$filePath},line={$error['line']}::{$message}\n";
     }
-
-    private function relativePath(string $currentWorkingDirectory, string $path): string
-    {
-        return str_replace($currentWorkingDirectory . '/', '', $path);
-    }
 }