Count syntax errors caused by a mutatan as a failure of a mutant (#1571)

Fixes #1569, related to #1555
infection · Sep 11, 2021 · 86e423c · 86e423c
1 parent 5c18760
commit 86e423c
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 7 deletions.
diff --git a/src/Metrics/Calculator.php b/src/Metrics/Calculator.php
@@ -77,7 +77,7 @@ public static function fromMetrics(MetricsCalculator $calculator): self
         return new self(
             $calculator->getRoundingPrecision(),
             $calculator->getKilledCount(),
-            $calculator->getErrorCount(),
+            $calculator->getErrorCount() + $calculator->getSyntaxErrorCount(),
             $calculator->getTimedOutCount(),
             $calculator->getNotTestedCount(),
             $calculator->getTestedMutantsCount()

diff --git a/tests/phpunit/Logger/JsonLoggerTest.php b/tests/phpunit/Logger/JsonLoggerTest.php
@@ -112,9 +112,9 @@ public function metricsProvider(): iterable
                     'syntaxErrorCount' => 2,
                     'skippedCount' => 2,
                     'timeOutCount' => 2,
-                    'msi' => 50,
+                    'msi' => 66.67,
                     'mutationCodeCoverage' => 83.33,
-                    'coveredCodeMsi' => 60,
+                    'coveredCodeMsi' => 80,
                 ],
                 'escaped' => [
                     [

diff --git a/tests/phpunit/Logger/PerMutatorLoggerTest.php b/tests/phpunit/Logger/PerMutatorLoggerTest.php
@@ -80,8 +80,8 @@ public function metricsProvider(): iterable
 
 | Mutator   | Mutations | Killed | Escaped | Errors | Syntax Errors | Timed Out | Skipped | MSI (%s) | Covered MSI (%s) |
 | --------- | --------- | ------ | ------- | ------ | ------------- | --------- | ------- | -------- | ---------------- |
-| For_      |         7 |      1 |       1 |      1 |             1 |         1 |       1 |    50.00 |            60.00 |
-| PregQuote |         7 |      1 |       1 |      1 |             1 |         1 |       1 |    50.00 |            60.00 |
+| For_      |         7 |      1 |       1 |      1 |             1 |         1 |       1 |    66.67 |            80.00 |
+| PregQuote |         7 |      1 |       1 |      1 |             1 |         1 |       1 |    66.67 |            80.00 |
 
 TXT
         ];

diff --git a/tests/phpunit/Metrics/CalculatorTest.php b/tests/phpunit/Metrics/CalculatorTest.php
@@ -174,9 +174,9 @@ public function metricsCalculatorProvider(): iterable
 
         yield 'nominal' => [
             $this->createCompleteMetricsCalculator(),
-            50.,  // 14 total mutations; 2 skipped; 6 of 12 are killed => 50%
+            66.67,  // 14 total mutations; 2 skipped; 8 of 12 are killed => 66.67%
             83.33, // 14 total mutations; 2 skipped & 2 not covered; => 10 of 12 => 83.33%
-            60.0, // 14 total mutations; 2 skipped & 2 not covered; 6 of 10 are killed => 60%
+            80.0, // 14 total mutations; 2 skipped & 2 not covered; 8 of 10 are killed => 80%
         ];
     }
 }