Rename SideEffectPredictorVisitor

infection · Jan 9, 2021 · 81b26df · 81b26df
1 parent 0fa353b
commit 81b26df
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 20 deletions.
diff --git a/src/Mutator/Augmentation/ExpressionRepeat.php b/src/Mutator/Augmentation/ExpressionRepeat.php
@@ -39,7 +39,7 @@
 use Infection\Mutator\GetMutatorName;
 use Infection\Mutator\Mutator;
 use Infection\Mutator\MutatorCategory;
-use Infection\PhpParser\Visitor\SideEffectPredictorVisitor;
+use Infection\PhpParser\Visitor\ImpureExpressionVisitor;
 use PhpParser\Node;
 
 /**
@@ -75,6 +75,6 @@ public function canMutate(Node $node): bool
         }
 
         // Skip statements with almost no side effects.
-        return $node->getAttribute(SideEffectPredictorVisitor::HAS_NODES_WITH_SIDE_EFFECTS_KEY);
+        return $node->getAttribute(ImpureExpressionVisitor::HAS_NODES_WITH_SIDE_EFFECTS_KEY);
     }
 }
diff --git a/src/PhpParser/NodeTraverserFactory.php b/src/PhpParser/NodeTraverserFactory.php
@@ -39,10 +39,10 @@
 use Infection\PhpParser\Visitor\IgnoreNode\AbstractMethodIgnorer;
 use Infection\PhpParser\Visitor\IgnoreNode\InterfaceIgnorer;
 use Infection\PhpParser\Visitor\IgnoreNode\NodeIgnorer;
+use Infection\PhpParser\Visitor\ImpureExpressionVisitor;
 use Infection\PhpParser\Visitor\NonMutableNodesIgnorerVisitor;
 use Infection\PhpParser\Visitor\ParentConnectorVisitor;
 use Infection\PhpParser\Visitor\ReflectionVisitor;
-use Infection\PhpParser\Visitor\SideEffectPredictorVisitor;
 use PhpParser\NodeTraverser;
 use PhpParser\NodeTraverserInterface;
 use PhpParser\NodeVisitor;
@@ -75,7 +75,7 @@ public function create(NodeVisitor $mutationVisitor, array $nodeIgnorers): NodeT
         $traverser->addVisitor(new ParentConnectorVisitor());
         $traverser->addVisitor(new FullyQualifiedClassNameVisitor());
         $traverser->addVisitor(new ReflectionVisitor());
-        $traverser->addVisitor(new SideEffectPredictorVisitor());
+        $traverser->addVisitor(new ImpureExpressionVisitor());
         $traverser->addVisitor($mutationVisitor);
 
         return $traverser;

diff --git a/...er/Visitor/SideEffectPredictorVisitor.php → ...arser/Visitor/ImpureExpressionVisitor.php b/...er/Visitor/SideEffectPredictorVisitor.php → ...arser/Visitor/ImpureExpressionVisitor.php
@@ -41,7 +41,7 @@
 /**
  * @internal
  */
-final class SideEffectPredictorVisitor extends NodeVisitorAbstract
+final class ImpureExpressionVisitor extends NodeVisitorAbstract
 {
     public const HAS_NODES_WITH_SIDE_EFFECTS_KEY = 'withSideEffects';
 

diff --git a/tests/phpunit/PhpParser/NodeTraverserFactoryTest.php b/tests/phpunit/PhpParser/NodeTraverserFactoryTest.php
@@ -40,10 +40,10 @@
 use Infection\PhpParser\Visitor\FullyQualifiedClassNameVisitor;
 use Infection\PhpParser\Visitor\IgnoreNode\AbstractMethodIgnorer;
 use Infection\PhpParser\Visitor\IgnoreNode\InterfaceIgnorer;
+use Infection\PhpParser\Visitor\ImpureExpressionVisitor;
 use Infection\PhpParser\Visitor\NonMutableNodesIgnorerVisitor;
 use Infection\PhpParser\Visitor\ParentConnectorVisitor;
 use Infection\PhpParser\Visitor\ReflectionVisitor;
-use Infection\PhpParser\Visitor\SideEffectPredictorVisitor;
 use Infection\Tests\Fixtures\PhpParser\FakeIgnorer;
 use Infection\Tests\Fixtures\PhpParser\FakeVisitor;
 use PhpParser\NodeTraverser;
@@ -75,7 +75,7 @@ public function test_it_can_create_a_traverser(): void
                 ParentConnectorVisitor::class,
                 FullyQualifiedClassNameVisitor::class,
                 ReflectionVisitor::class,
-                SideEffectPredictorVisitor::class,
+                ImpureExpressionVisitor::class,
                 FakeVisitor::class,
             ],
             $visitors
@@ -103,7 +103,7 @@ public function test_it_can_create_a_traverser_with_node_ignorers(): void
                 ParentConnectorVisitor::class,
                 FullyQualifiedClassNameVisitor::class,
                 ReflectionVisitor::class,
-                SideEffectPredictorVisitor::class,
+                ImpureExpressionVisitor::class,
                 FakeVisitor::class,
             ],
             $visitorClasses

diff --git a/...isitor/SideEffectPredictorVisitorTest.php → ...r/Visitor/ImpureExpressionVisitorTest.php b/...isitor/SideEffectPredictorVisitorTest.php → ...r/Visitor/ImpureExpressionVisitorTest.php
@@ -35,15 +35,15 @@
 
 namespace Infection\Tests\PhpParser\Visitor;
 
-use Infection\PhpParser\Visitor\SideEffectPredictorVisitor;
+use Infection\PhpParser\Visitor\ImpureExpressionVisitor;
 use PhpParser\Node;
 use PHPUnit\Framework\TestCase;
 
-final class SideEffectPredictorVisitorTest extends TestCase
+final class ImpureExpressionVisitorTest extends TestCase
 {
     public function test_it_returns_null_when_entering_node(): void
     {
-        $visitor = new SideEffectPredictorVisitor();
+        $visitor = new ImpureExpressionVisitor();
 
         $nodeMock = $this->createNotExpectingAnythingNodeMock();
 
@@ -52,7 +52,7 @@ public function test_it_returns_null_when_entering_node(): void
 
     public function test_it_returns_null_when_leaving_node(): void
     {
-        $visitor = new SideEffectPredictorVisitor();
+        $visitor = new ImpureExpressionVisitor();
 
         $nodeMock = $this->createNotExpectingAnythingNodeMock();
 
@@ -61,7 +61,7 @@ public function test_it_returns_null_when_leaving_node(): void
 
     public function test_it_does_not_update_attribute_for_non_expressions(): void
     {
-        $visitor = new SideEffectPredictorVisitor();
+        $visitor = new ImpureExpressionVisitor();
 
         $nodeMock = $this->createNotExpectingAnythingNodeMock();
 
@@ -70,7 +70,7 @@ public function test_it_does_not_update_attribute_for_non_expressions(): void
 
     public function test_it_updates_attribute_for_expression(): void
     {
-        $visitor = new SideEffectPredictorVisitor();
+        $visitor = new ImpureExpressionVisitor();
 
         $expressionMock = $this->createExpressionMock(false);
 
@@ -79,7 +79,7 @@ public function test_it_updates_attribute_for_expression(): void
 
     public function test_it_updates_attribute_with_default_value(): void
     {
-        $visitor = new SideEffectPredictorVisitor();
+        $visitor = new ImpureExpressionVisitor();
 
         $expressionMock = $this->createNotExpectingAnythingNodeMock(Node\Stmt\Expression::class);
         $visitor->enterNode($expressionMock);
@@ -90,7 +90,7 @@ public function test_it_updates_attribute_with_default_value(): void
 
     public function test_it_updates_attribute_to_true_after_seeing_method_call(): void
     {
-        $visitor = new SideEffectPredictorVisitor();
+        $visitor = new ImpureExpressionVisitor();
 
         $expressionMock = $this->createNotExpectingAnythingNodeMock(Node\Stmt\Expression::class);
         $visitor->enterNode($expressionMock);
@@ -104,7 +104,7 @@ public function test_it_updates_attribute_to_true_after_seeing_method_call(): vo
 
     public function test_it_updates_attribute_to_true_after_seeing_unnamed_function_call(): void
     {
-        $visitor = new SideEffectPredictorVisitor();
+        $visitor = new ImpureExpressionVisitor();
 
         $expressionMock = $this->createNotExpectingAnythingNodeMock(Node\Stmt\Expression::class);
         $visitor->enterNode($expressionMock);
@@ -122,7 +122,7 @@ public function test_it_updates_attribute_to_true_after_seeing_unnamed_function_
      */
     public function test_it_updates_attribute_to_false_after_seeing_restricted_node(string $nodeClassName): void
     {
-        $visitor = new SideEffectPredictorVisitor();
+        $visitor = new ImpureExpressionVisitor();
 
         $expressionMock = $this->createNotExpectingAnythingNodeMock(Node\Stmt\Expression::class);
         $visitor->enterNode($expressionMock);
@@ -145,7 +145,7 @@ public function test_it_updates_attribute_to_false_after_seeing_restricted_node(
      */
     public function test_it_keeps_attribute_at_true_after_seeing_restricted_node_on_level_above(string $nodeClassName): void
     {
-        $visitor = new SideEffectPredictorVisitor();
+        $visitor = new ImpureExpressionVisitor();
 
         $expressionMock = $this->createNotExpectingAnythingNodeMock(Node\Stmt\Expression::class);
         $visitor->enterNode($expressionMock);
@@ -202,7 +202,7 @@ private function createExpressionMock(bool $attributeValue): Node\Stmt\Expressio
             ->expects($this->once())
             ->method('setAttribute')
             ->with(
-                SideEffectPredictorVisitor::HAS_NODES_WITH_SIDE_EFFECTS_KEY,
+                ImpureExpressionVisitor::HAS_NODES_WITH_SIDE_EFFECTS_KEY,
                 $attributeValue
             )
         ;