Remove interface and abstraction checks in public visitor

infection · Mar 9, 2019 · 6593925 · 6593925
1 parent 648ba9c
commit 6593925
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 75 deletions.
diff --git a/src/Mutator/FunctionSignature/PublicVisibility.php b/src/Mutator/FunctionSignature/PublicVisibility.php
@@ -35,7 +35,6 @@
 
 namespace Infection\Mutator\FunctionSignature;
 
-use Infection\Mutator\Util\InterfaceParentTrait;
 use Infection\Mutator\Util\Mutator;
 use Infection\Visitor\ReflectionVisitor;
 use PhpParser\Node;
@@ -47,8 +46,6 @@
  */
 final class PublicVisibility extends Mutator
 {
-    use InterfaceParentTrait;
-
     /**
      * Replaces "public function..." with "protected function ..."
      *
@@ -81,18 +78,10 @@ protected function mutatesNode(Node $node): bool
             return false;
         }
 
-        if ($node->isAbstract()) {
-            return false;
-        }
-
         if ($node->isMagic()) {
             return false;
         }
 
-        if ($this->isBelongsToInterface($node)) {
-            return false;
-        }
-
         return !$this->hasSamePublicParentMethod($node);
     }
 

diff --git a/src/Mutator/Util/InterfaceParentTrait.php b/src/Mutator/Util/InterfaceParentTrait.php
diff --git a/tests/Mutator/AbstractMutatorTestCase.php b/tests/Mutator/AbstractMutatorTestCase.php
@@ -42,6 +42,7 @@
 use Infection\Tests\Fixtures\SimpleMutatorVisitor;
 use Infection\Visitor\CloneVisitor;
 use Infection\Visitor\FullyQualifiedClassNameVisitor;
+use Infection\Visitor\NotMutableIgnoreVisitor;
 use Infection\Visitor\ParentConnectorVisitor;
 use Infection\Visitor\ReflectionVisitor;
 use PhpParser\Lexer;
@@ -152,6 +153,7 @@ private function getMutationsFromCode(string $code, Parser $parser, array $setti
 
         $mutationsCollectorVisitor = new SimpleMutationsCollectorVisitor($this->getMutator($settings), $initialStatements);
 
+        $traverser->addVisitor(new NotMutableIgnoreVisitor());
         $traverser->addVisitor($mutationsCollectorVisitor);
         $traverser->addVisitor(new ParentConnectorVisitor());
         $traverser->addVisitor(new FullyQualifiedClassNameVisitor());