JsonFileTest should fail if file is not found

infection · Mar 23, 2019 · 0d91b4e · 0d91b4e
1 parent b9322bf
commit 0d91b4e
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/Json/JsonFile.php b/src/Json/JsonFile.php
@@ -71,6 +71,10 @@ public function decode(): \stdClass
 
     private function parse(): void
     {
+        if (!is_file($this->path)) {
+            throw ParseException::invalidJson($this->path, 'file not found');
+        }
+
         $data = json_decode((string) file_get_contents($this->path));
 
         if (null === $data && JSON_ERROR_NONE !== json_last_error()) {

diff --git a/tests/Json/JsonFileTest.php b/tests/Json/JsonFileTest.php
@@ -101,6 +101,16 @@ public function test_it_throws_parse_exception_with_invalid_json(): void
         (new JsonFile($jsonPath))->decode();
     }
 
+    public function test_it_throws_parse_exception_when_file_is_not_found(): void
+    {
+        $jsonPath = $this->tmpDir . '/missing-invalid.json';
+        self::assertFileNotExists($jsonPath);
+
+        self::expectException(ParseException::class);
+
+        (new JsonFile($jsonPath))->decode();
+    }
+
     public function test_it_throws_schema_validation_exception(): void
     {
         $jsonString = '{"timeout": 25}';