Trying to remove false positive on logical or. #862
Neirda24mt-annotations.yaml
on: pull_request
Matrix: tests
Annotations Status
1s
Annotations
10 warnings
|
Mutation Testing Code Review Annotations 8.0:
src/Mutator/Boolean/LogicalOr.php#L89
Escaped Mutant for Mutator "InstanceOf_":
--- Original
+++ New
@@ @@
}
$nodeLeft = $node->left;
$nodeRight = $node->right;
- if (!$nodeLeft instanceof Node\Expr\BinaryOp || !$nodeRight instanceof Node\Expr\BinaryOp) {
+ if (!true || !$nodeRight instanceof Node\Expr\BinaryOp) {
return true;
}
$nodeLeftLeft = $nodeLeft->left;
|
|
Mutation Testing Code Review Annotations 8.0:
src/Mutator/Boolean/LogicalOr.php#L89
Escaped Mutant for Mutator "LogicalOr":
--- Original
+++ New
@@ @@
}
$nodeLeft = $node->left;
$nodeRight = $node->right;
- if (!$nodeLeft instanceof Node\Expr\BinaryOp || !$nodeRight instanceof Node\Expr\BinaryOp) {
+ if (!$nodeLeft instanceof Node\Expr\BinaryOp && !$nodeRight instanceof Node\Expr\BinaryOp) {
return true;
}
$nodeLeftLeft = $nodeLeft->left;
|
|
Mutation Testing Code Review Annotations 8.0:
src/Mutator/Boolean/LogicalOr.php#L90
Escaped Mutant for Mutator "InstanceOf_":
--- Original
+++ New
@@ @@
}
$nodeLeft = $node->left;
$nodeRight = $node->right;
- if (!$nodeLeft instanceof Node\Expr\BinaryOp || !$nodeRight instanceof Node\Expr\BinaryOp) {
+ if (!$nodeLeft instanceof Node\Expr\BinaryOp || !true) {
return true;
}
$nodeLeftLeft = $nodeLeft->left;
|
|
Mutation Testing Code Review Annotations 8.0:
src/Mutator/Boolean/LogicalOr.php#L102
Escaped Mutant for Mutator "InstanceOf_":
--- Original
+++ New
@@ @@
$nodeLeftRight = $nodeLeft->right;
$nodeRightLeft = $nodeRight->left;
$nodeRightRight = $nodeRight->right;
- if ($nodeLeft instanceof Node\Expr\BinaryOp\Identical && $nodeRight instanceof Node\Expr\BinaryOp\Identical) {
+ if (true && $nodeRight instanceof Node\Expr\BinaryOp\Identical) {
$varNameLeft = [];
if ($nodeLeftLeft instanceof Node\Expr\Variable) {
$varNameLeft[] = $nodeLeftLeft->name;
|
|
Mutation Testing Code Review Annotations 8.0:
src/Mutator/Boolean/LogicalOr.php#L129
Escaped Mutant for Mutator "LogicalOr":
--- Original
+++ New
@@ @@
}
return array_intersect($varNameLeft, $varNameRight) === [];
}
- if ($nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\Greater || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Greater) {
+ if ($nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\Smaller && ($nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual) || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\Greater || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Greater) {
$varNameLeft = null;
$valueLeft = null;
if ($nodeLeftLeft instanceof Node\Expr\Variable) {
|
|
Mutation Testing Code Review Annotations 8.0:
src/Mutator/Boolean/LogicalOr.php#L129
Escaped Mutant for Mutator "LogicalOr":
--- Original
+++ New
@@ @@
}
return array_intersect($varNameLeft, $varNameRight) === [];
}
- if ($nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\Greater || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Greater) {
+ if (($nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual) && ($nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual) || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\Greater || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Greater) {
$varNameLeft = null;
$valueLeft = null;
if ($nodeLeftLeft instanceof Node\Expr\Variable) {
|
|
Mutation Testing Code Review Annotations 8.0:
src/Mutator/Boolean/LogicalOr.php#L129
Escaped Mutant for Mutator "LogicalOr":
--- Original
+++ New
@@ @@
}
return array_intersect($varNameLeft, $varNameRight) === [];
}
- if ($nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\Greater || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Greater) {
+ if (($nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual) && ($nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Smaller) || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\Greater || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Greater) {
$varNameLeft = null;
$valueLeft = null;
if ($nodeLeftLeft instanceof Node\Expr\Variable) {
|
|
Mutation Testing Code Review Annotations 8.0:
src/Mutator/Boolean/LogicalOr.php#L130
Escaped Mutant for Mutator "InstanceOf_":
--- Original
+++ New
@@ @@
}
return array_intersect($varNameLeft, $varNameRight) === [];
}
- if ($nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\Greater || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Greater) {
+ if (true && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\Greater || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Greater) {
$varNameLeft = null;
$valueLeft = null;
if ($nodeLeftLeft instanceof Node\Expr\Variable) {
|
|
Mutation Testing Code Review Annotations 8.0:
src/Mutator/Boolean/LogicalOr.php#L130
Escaped Mutant for Mutator "InstanceOf_":
--- Original
+++ New
@@ @@
}
return array_intersect($varNameLeft, $varNameRight) === [];
}
- if ($nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\Greater || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Greater) {
+ if (false && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\Greater || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Greater) {
$varNameLeft = null;
$valueLeft = null;
if ($nodeLeftLeft instanceof Node\Expr\Variable) {
|
|
Mutation Testing Code Review Annotations 8.0:
src/Mutator/Boolean/LogicalOr.php#L130
Escaped Mutant for Mutator "LogicalAnd":
--- Original
+++ New
@@ @@
}
return array_intersect($varNameLeft, $varNameRight) === [];
}
- if ($nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\Greater || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Greater) {
+ if ($nodeLeft instanceof Node\Expr\BinaryOp\Greater || $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Greater && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\SmallerOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\GreaterOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Smaller || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\Greater || $nodeLeft instanceof Node\Expr\BinaryOp\Smaller && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\GreaterOrEqual || $nodeLeft instanceof Node\Expr\BinaryOp\SmallerOrEqual && $nodeRight instanceof Node\Expr\BinaryOp\Greater) {
$varNameLeft = null;
$valueLeft = null;
if ($nodeLeftLeft instanceof Node\Expr\Variable) {
|