-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added vim-like count feature for certain commands #144
base: main
Are you sure you want to change the base?
Conversation
see issue inducer#140 supported commands: run to cursor; movements(j/k/h/l); stack movements(u/d) Bug: UI is not correctly updated at the program termination
Is it possible to make it work with arrow keys too? |
Should we add some kind of indicator to the UI so the user can see what number they've typed? |
Seems like |
existing_breaks = self.debugger.get_breaks(bp_source_identifier, pos+1) | ||
if existing_breaks: | ||
assert len(existing_breaks) == 1,\ | ||
"Expect one breakpoint at line %d, got %d" % (pos+1, len(existing_breaks)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got this error. I think it occurs when you use t
on a line that is already set as a breakpoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi asmeurer, thanks for the feedback. It's not obvious to me how to solve this. The normal breakpoint alway break therefore makes the ignore count of temporary breakpoint useless.
I think that a possible solution would be to disable the normal breakpoint and reenable them after the temporary breakpoints used. But it seems that there's no clean way to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think only temporary breakpoints should be ignored, right? Is there some way to not ignore manually set breakpoints?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand your statement correctly. Manually set breakpoint are never ignored and breaks each time it's met, and therefore would interfere with temporary breakpoint that are set to be ignored for a specified times.
The I agree that UI indicator would be great. But I'm not very familiar with pudb's UI codebase, so I would need some help on that. Unfortunately |
see issue #140
supported commands: run to cursor; movements(j/k/h/l); stack movements(u/d)
Bug: UI is not correctly updated if program terminated after count command