Phpunit 9 compatibility #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, in phpunit 7 and 8 it was ok to have a class with a different name in the file. 9 wouldn’t allow it so I changed the class name to match the filename.
In PHPUnit 9, the ResultPrinter is an interface so using the printer would generate an error. By changed the base Printer class to DefaultResultPrinter functionality is restored.
Due to internal changes between phpunit 8 & 9, this update breaks backwards compatiblity with with any phpunit version lower than 9.
|
Also, Travis needs PHP 7.3 due to dependency constraints ;) |
|
Thanks for your contribution. We decided to merge an other PR to solve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a compatiblity error with PHPUnit 9. When using this printer, the following error occurs:
This is due to a class which was marked internal in 8 which is now an interface in 9. Check out sebastianbergmann/phpunit#4024 for more info.
This pull request changes the parent class so the printer functions again. The downside is that there is no backwards compatibility with earlier versions of PHPUnit.
Let me know what you think :)