Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch caching implementation #57

Merged
merged 4 commits into from Jan 22, 2019
Merged

Switch caching implementation #57

merged 4 commits into from Jan 22, 2019

Conversation

ctmay4
Copy link
Member

@ctmay4 ctmay4 commented Jan 22, 2019

The library is currently using Caffeine. That library still uses sun.misc.Unsafe. There is an issue to look into it (ben-manes/caffeine#273), but there has been no movement.

This merge request switches the caching library to Cache2k which has no deprecated dependencies and it fully compatible with Java 9+.

@ctmay4 ctmay4 added the cleanup label Jan 22, 2019
@ctmay4 ctmay4 self-assigned this Jan 22, 2019
@ctmay4 ctmay4 merged commit 4fbe2ee into master Jan 22, 2019
@ctmay4 ctmay4 deleted the cache2k branch January 30, 2019 18:38
@ctmay4
Copy link
Member Author

ctmay4 commented Feb 1, 2019

The new library is working well. The performance in heavily threaded workflows is improved as well.

Caffeine

Starting schema selection tests from cs_schema_identification.txt.gz [7 threads]
Completed 8,908,918 cases in 19.59 s (0.002ms/case).
Starting carcinoid_appendix.gz [7 threads]
Completed 2,565,807 cases for carcinoid_appendix.gz in 1.404 min (0.033ms/case).

Cache2k

Starting schema selection tests from cs_schema_identification.txt.gz [7 threads]
Completed 8,908,918 cases in 15.02 s (0.002ms/case).
Starting carcinoid_appendix.gz [7 threads]
Completed 2,565,807 cases for carcinoid_appendix.gz in 1.345 min (0.031ms/case).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant