Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecated flags to imports-first metadata #625

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const rules = {
'no-deprecated': require('./rules/no-deprecated'),

// deprecated aliases to rules
'imports-first': require('./rules/first'),
'imports-first': require('./rules/imports-first'),
}

export const configs = {
Expand Down
5 changes: 5 additions & 0 deletions src/rules/imports-first.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import first from './first'

const newMeta = Object.assign({}, first.meta, { deprecated: true })

module.exports = Object.assign({}, first, { meta: newMeta })
6 changes: 5 additions & 1 deletion tests/src/package.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,9 @@ describe('package', function () {
}
})

})
it('marks deprecated rules in their metadata', function () {
expect(module.rules['imports-first'].meta.deprecated).to.be.true
expect(module.rules['first'].meta.deprecated).not.to.be.true
})

})