Destructured exports no unused modules

[KristjanTammekivi]

Fixes #2037

[coveralls]

Coverage increased (+12.9%) to 84.007% when pulling 2057c05 on KristjanTammekivi:destructured-exports-no-unused-modules into 5898e28 on benmosher:master.

[ljharb]

Named exports aren’t destructuring; please update the terminology :-)

[KristjanTammekivi]

I don't see how export const { a } = { a: 5 }; is not destructuring? In MDN there's an example of destructured assignments

// Exporting destructured assignments with renaming
export const { name1, name2: bar } = o;

[ljharb]

Ohh, i misunderstood! Thanks.

[ljharb]

Thanks, seems good

[ljharb]

(Note that merging this is blocked on #1986)

[ljharb]

This was actually fixed by #1997, but I've rebased this to keep the test.

[emreboga]

Hey @ljharb, I don't think this was fully fixed by #1997 as it only addresses object type destucturing, not including array types. You can see it in the code:
https://github.com/import-js/eslint-plugin-import/pull/1997/files#diff-7d2908b010ec724c0f3a0d7615cb91f4673d765d52c6ba6607501e23470f2966R85

I'm seeing this in the code with the version 2.28.1, which has the fix with #1997. Here is a code chunk I have:

export const [authUserLoading, authUserError] = createLoadingAndErrorSelectors(
  AUTH_USER
);

and here is the error I get:

error  exported declaration 'undefined' not used within other modules  import/no-unused-modules

[ljharb]

@emreboga interesting - would you mind filing a new issue about that one?

[emreboga]

@ljharb Sure! Please see #2930