Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] first/TypeScript: Add support for import = expressions #1917

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[New] first/TypeScript: Add support for import = expressions #1917

wants to merge 1 commit into from

Conversation

ExE-Boss
Copy link

@ExE-Boss ExE-Boss commented Oct 4, 2020 •
edited

See #1244 (comment) and #1785.

review?(@ljharb)

@coveralls
Copy link

coveralls commented Oct 4, 2020 •
edited

Coverage Status

Coverage decreased (-0.2%) to 97.669% when pulling f897599 on EB-Forks:rules/first/ts-import-equals-declaration into a00727e on benmosher:master.

ljharb
ljharb approved these changes Jan 25, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ljharb
Copy link
Member

ljharb commented Jan 26, 2021

@ExE-Boss This was already fixed by #1963. I'd like to rebase it to add the tests, but I can't push to EB-Forks.

@ljharb ljharb marked this pull request as draft January 31, 2021 03:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ExE-Boss @coveralls @ljharb