Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import/no-cycle triggering errors for Flow imports #1494

Merged
merged 1 commit into from
Dec 5, 2019
Merged

fix: import/no-cycle triggering errors for Flow imports #1494

merged 1 commit into from
Dec 5, 2019

Conversation

maxmalov
Copy link
Contributor

@maxmalov maxmalov commented Oct 5, 2019

The changes fix a complex circular dependency where Flow type imports are transient dependencies of the checked module. Basically such imports can be ignored too since they will be stripped anyway

Fixes #1343

@maxmalov maxmalov changed the title Fix import/no-cycle triggering errors for Flow imports fix: import/no-cycle triggering errors for Flow imports Oct 5, 2019
@coveralls
Copy link

coveralls commented Oct 5, 2019

Coverage Status

Coverage decreased (-0.3%) to 96.07% when pulling 21bf8c6 on maxmalov:fix-flow-type-cycles into 0cd5e43 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.8%) to 92.574% when pulling 67ff5b8 on maxmalov:fix-flow-type-cycles into 5e143b2 on benmosher:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.8%) to 92.574% when pulling 67ff5b8 on maxmalov:fix-flow-type-cycles into 5e143b2 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.8%) to 92.574% when pulling 67ff5b8 on maxmalov:fix-flow-type-cycles into 5e143b2 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.8%) to 92.574% when pulling 67ff5b8 on maxmalov:fix-flow-type-cycles into 5e143b2 on benmosher:master.

@dominicfraser
Copy link

@102 @maxmalov - could we have an update on the status of this PR? :)

@maxmalov
Copy link
Contributor Author

@dominicfraser yeah, the fix supposed to handle both type import variants import type { Foo } and import { type Bar }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

import/no-cycle should not trigger for Flow imports
5 participants