Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor] use native JS instead of lodash #1419

Merged
merged 5 commits into from
Jul 17, 2019
Merged

[Refactor] use native JS instead of lodash #1419

merged 5 commits into from
Jul 17, 2019

Commits on Jul 17, 2019

  1. [Refactor] importType: remove use of cond 

    Using normal JS makes for far more understandable and maintainable code.
    @ljharb
    ljharb committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    c5078ad View commit details
    Browse the repository at this point in the history

  2. [Refactor] no-extraneous-dependencies: use Array.isArray instead … 

    …of lodash
    @ljharb
    ljharb committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    8a38fd4 View commit details
    Browse the repository at this point in the history

  3. [Refactor] no-extraneous-dependencies: remove the last bit of lodash 

    Using `.length` is clearer than a polymorphic `isEmpty`.
    @ljharb
    ljharb committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    d3a3fa5 View commit details
    Browse the repository at this point in the history

  4. [Tests] add missing --no-save to time travel script

    @ljharb
    ljharb committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    752dcd5 View commit details
    Browse the repository at this point in the history

  5. [Tests] temporarily disable these failing tests in eslint < 4

    @ljharb
    ljharb committed Jul 17, 2019
    Configuration menu
    Copy the full SHA
    5abd5ed View commit details
    Browse the repository at this point in the history