inlineTypeImport to preferInline

import-js · Nov 6, 2022 · ecd0082 · ecd0082
1 parent 7263156
commit ecd0082
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/docs/rules/no-duplicates.md b/docs/rules/no-duplicates.md
@@ -69,12 +69,12 @@ import * from './mod.js?minify'
 
 ### Inline Type imports
 
-TypeScript 4.5 introduced a new [feature](https://devblogs.microsoft.com/typescript/announcing-typescript-4-5/#type-on-import-names) that allows mixing of named value and type imports. In order to support fixing to an inline type import when duplicate imports are detected, `inlineTypeImport` can be set to true.
+TypeScript 4.5 introduced a new [feature](https://devblogs.microsoft.com/typescript/announcing-typescript-4-5/#type-on-import-names) that allows mixing of named value and type imports. In order to support fixing to an inline type import when duplicate imports are detected, `preferInline` can be set to true.
 
 Config:
 
 ```json
-"import/no-duplicates": ["error", {"inlineTypeImport": true}]
+"import/no-duplicates": ["error", {"preferInline": true}]
 ```
 
 ```js

diff --git a/src/rules/no-duplicates.js b/src/rules/no-duplicates.js
@@ -109,8 +109,8 @@ function getFix(first, rest, sourceCode, context) {
     const [specifiersText] = specifiers.reduce(
       ([result, needsComma], specifier) => {
         const isTypeSpecifier = specifier.importNode.importKind === 'type';
-        const inlineTypeImport = context.options[0] && context.options[0].inlineTypeImport;
-        const insertText = `${inlineTypeImport && isTypeSpecifier ? 'type ' : ''}${specifier.text}`;
+        const preferInline = context.options[0] && context.options[0].preferInline;
+        const insertText = `${preferInline && isTypeSpecifier ? 'type ' : ''}${specifier.text}`;
         return [
           needsComma && !specifier.isEmpty
             ? `${result},${insertText}`
@@ -260,7 +260,7 @@ module.exports = {
           considerQueryString: {
             type: 'boolean',
           },
-          inlineTypeImport: {
+          preferInline: {
             type: 'boolean',
           },
         },

diff --git a/tests/src/rules/no-duplicates.js b/tests/src/rules/no-duplicates.js
@@ -538,7 +538,7 @@ context('TypeScript', function () {
         test({
           code: "import {type x} from './foo'; import type {y} from './foo'",
           ...parserConfig,
-          options: [{ 'inlineTypeImport': false }],
+          options: [{ 'preferInline': false }],
           output: `import {type x,y} from './foo'; `,
           errors: [
             {
@@ -556,7 +556,7 @@ context('TypeScript', function () {
         test({
           code: "import {type x} from 'foo'; import type {y} from 'foo'",
           ...parserConfig,
-          options: [{ 'inlineTypeImport': true }],
+          options: [{ 'preferInline': true }],
           output: `import {type x,type y} from 'foo'; `,
           errors: [
             {