Skip to content

Commit

Permalink
[Fix]: test cases of no-amd and no-commonjs
Browse files Browse the repository at this point in the history
  • Loading branch information
ota-meshi committed Aug 16, 2021
1 parent 8be2ec2 commit d4739ca
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
5 changes: 4 additions & 1 deletion tests/src/rules/no-amd.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { RuleTester } from 'eslint';
import eslintPkg from 'eslint/package.json';
import semver from 'semver';

const ruleTester = new RuleTester();
const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2015, sourceType: 'module' } });

ruleTester.run('no-amd', require('rules/no-amd'), {
valid: [
Expand All @@ -25,6 +25,9 @@ ruleTester.run('no-amd', require('rules/no-amd'), {
// unmatched arg types/number
'define(0, 1, 2)',
'define("a")',

// sourceType: 'script'
{ code: 'define([], function(a) {})', parserOptions: { ecmaVersion: 2015, sourceType: 'script' } },
],

invalid: semver.satisfies(eslintPkg.version, '< 4.0.0') ? [] : [
Expand Down
5 changes: 4 additions & 1 deletion tests/src/rules/no-commonjs.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import semver from 'semver';
const EXPORT_MESSAGE = 'Expected "export" or "export default"';
const IMPORT_MESSAGE = 'Expected "import" instead of "require()"';

const ruleTester = new RuleTester();
const ruleTester = new RuleTester({ parserOptions: { ecmaVersion: 2015, sourceType: 'module' } });

ruleTester.run('no-commonjs', require('rules/no-commonjs'), {
valid: [
Expand Down Expand Up @@ -63,6 +63,9 @@ ruleTester.run('no-commonjs', require('rules/no-commonjs'), {
{ code: 'if (typeof window !== "undefined") { require("x") }', options: [{ allowRequire: false }] },

{ code: 'try { require("x") } catch (error) {}' },

// sourceType: 'script'
{ code: 'var x = require("x")', parserOptions: { ecmaVersion: 2015, sourceType: 'script' } },
],

invalid: [
Expand Down

0 comments on commit d4739ca

Please sign in to comment.