Skip to content

Commit

Permalink
[Defect 2066] add extraneous-dependencies unit tests
Browse files Browse the repository at this point in the history
  • Loading branch information
jeromeh committed May 26, 2021
1 parent d7119ef commit c612d14
Show file tree
Hide file tree
Showing 6 changed files with 19 additions and 2 deletions.
1 change: 1 addition & 0 deletions tests/files/node_modules/rxjs/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions tests/files/node_modules/rxjs/operators/index.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions tests/files/node_modules/rxjs/operators/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions tests/files/node_modules/rxjs/package.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion tests/files/package.json
Expand Up @@ -11,7 +11,8 @@
"@org/package": "^1.0.0",
"jquery": "^3.1.0",
"lodash.cond": "^4.3.0",
"pkg-up": "^1.0.0"
"pkg-up": "^1.0.0",
"rxjs": "^1.0.0"
},
"optionalDependencies": {
"lodash.isarray": "^4.0.0"
Expand Down
6 changes: 5 additions & 1 deletion tests/src/rules/no-extraneous-dependencies.js
Expand Up @@ -88,7 +88,7 @@ ruleTester.run('no-extraneous-dependencies', rule, {
}),
test({
code: `
// @flow
// @flow
import typeof TypeScriptModule from 'typescript';
`,
options: [{ packageDir: packageDirWithFlowTyped }],
Expand Down Expand Up @@ -150,6 +150,10 @@ ruleTester.run('no-extraneous-dependencies', rule, {
code: 'import "@generated/bar/and/sub/path"',
settings: { 'import/core-modules': ['@generated/bar'] },
}),
// check if "rxjs" dependency declaration fix the "rxjs/operators subpackage
test({
code: 'import "rxjs/operators"',
}),
],
invalid: [
test({
Expand Down

0 comments on commit c612d14

Please sign in to comment.