Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump tsconfig-paths to ^4.0.0 #104

Merged
merged 1 commit into from May 4, 2022

Conversation

F3n67u
Copy link
Contributor

@F3n67u F3n67u commented May 4, 2022

This deps upgrade will introduce a breaking change, because tsconfig-paths upgrade its json5 version to v2 which does not support node 4. see dividab/tsconfig-paths#198

If we want to upgrade tsconfig-paths to the latest, I think we could do it on the next major release and drop the node v4 support. But I am sure if it is accepted. @JounQin what do you think?

@JounQin
Copy link
Collaborator

JounQin commented May 4, 2022

Actually, it seems node<12 has not been tested for a long time, so it looks good to me personally.

@F3n67u F3n67u marked this pull request as ready for review May 4, 2022 13:33
@F3n67u
Copy link
Contributor Author

F3n67u commented May 4, 2022

Actually, it seems node<12 has not been tested for a lot time, so it looks good to me personally.

@JounQin Great! let's merge this pr if it looks good to you then.

@JounQin JounQin merged commit b2edbc8 into import-js:master May 4, 2022
@F3n67u F3n67u deleted the tsconfig-paths branch May 4, 2022 13:40
@JounQin
Copy link
Collaborator

JounQin commented May 4, 2022

@F3n67u Thanks, let's wait for import-js/eslint-plugin-import#2447 then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants