Fix counts in WriteResult for upsert operation #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@asereda-gs I made some changes based on your fix, hope it could be merged to the project |
|
Thanks for this PR! |
|
Now when I think, perhaps Take a look at WriteTemplate. Maybe something similar can be created (eg. called @dparamoshkin is it something you might be interested to implement ? |
|
Or another option is to enhance |
|
@asereda-gs I would check on weekend if I can improve something there |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes insert counters for the upsert operation described in #1376 Mongo doesn't provide it as
insertedCount, but it could be get from the size ofupsertscollection