fixing #1407 - Default value with explicit null should use default. #1410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure how Jackson/Immutables combination work in this case in terms of semantics, It's hard to me to say that it is justified of not to behave in this way, also I'm not sure how it's only surface with staged builder, seems to be a common problem. However, it's still looks innocent, even if a little bit lenient/non-strict behavior, so I'm merging this. I have no better way to fix this, and I have not strong opinions (any more) about how Jackson/Immutables combination should work in ideal word. Thank you for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing an issue with Jackson and staged builder feature interaction.
Essentially, null values are not allowed when the immutable entry is identified as not nullable.