Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve type infererence for Map #1907

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve type infererence for Map #1907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 9 additions & 5 deletions type-definitions/immutable.d.ts
View file
Open in desktop
Expand Up @@ -759,11 +759,15 @@ declare namespace Immutable {
* but since Immutable Map keys can be of any type the argument to `get()` is
* not altered.
*/
function Map<K, V>(collection?: Iterable<[K, V]>): Map<K, V>;
function Map<V>(obj: { [key: string]: V }): Map<string, V>;
function Map<K extends string | symbol, V>(obj: { [P in K]?: V }): Map<K, V>;

interface Map<K, V> extends Collection.Keyed<K, V> {
function Map<T extends Array<[string | number | symbol, unknown]>>(collection: T): Map<{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You changed from Iterable to Array. Can you make it back to iterable ? A List is iterable, but not an Array for example (but I'm not that sure as there is a test that validate this case 🤔 )

[P in T[number]as P[0]]: P[1]
}>;
function Map<T>(obj: T): (T extends Map<T>
? T
: Map<T>);

interface Map<T> extends IterableMap<keyof T, T[keyof T]> { }
Copy link
Author

@A0150315 A0150315 Jun 27, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was necessary to infer value from key from Object instead of <K,V> cause <K,V> will broke relation with K and V，then we can infer key and value by T in the future

interface IterableMap<K, V> extends Collection.Keyed<K, V> {
/**
* The number of entries in this Map.
*/
Expand Down