Fix Repeat(<value>).equals(undefined) incorrectly returning true (#1994)

* Add failing test case for Repeat(<value>).equals(undefined) * Fix Repeat(<value>).equals(undefined) incorrectly returning true
immutable-js · May 10, 2024 · be3cb9a · be3cb9a
1 parent d7664bf
commit be3cb9a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/__tests__/Repeat.ts b/__tests__/Repeat.ts
@@ -11,4 +11,8 @@ describe('Repeat', () => {
     expect(v.toArray()).toEqual(['wtf', 'wtf', 'wtf']);
     expect(v.join()).toEqual('wtf,wtf,wtf');
   });
+
+  it('does not claim to be equal to undefined', () => {
+    expect(Repeat(1).equals(undefined)).toEqual(false);
+  });
 });
diff --git a/src/Repeat.js b/src/Repeat.js
@@ -93,7 +93,7 @@ export class Repeat extends IndexedSeq {
   equals(other) {
     return other instanceof Repeat
       ? is(this._value, other._value)
-      : deepEqual(other);
+      : deepEqual(this, other);
   }
 }