fix Set.concat to concatenate strings as items (#1913)

immutable-js · Nov 17, 2022 · 908f205 · 908f205
1 parent 7cf6f8e
commit 908f205
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/__tests__/Set.ts b/__tests__/Set.ts
@@ -131,6 +131,11 @@ describe('Set', () => {
     expect(Set.intersect([])).toBe(Set());
   });
 
+  it('concatenates strings using union', () => {
+    const s = Set(['one', 'two']);
+    expect(s.union('three').toArray()).toEqual(['one', 'two', 'three']);
+  });
+
   it('iterates values', () => {
     const s = Set([1, 2, 3]);
     const iterator = jest.fn();

diff --git a/src/Set.js b/src/Set.js
@@ -104,7 +104,11 @@ export class Set extends SetCollection {
     }
     return this.withMutations(set => {
       for (let ii = 0; ii < iters.length; ii++) {
-        SetCollection(iters[ii]).forEach(value => set.add(value));
+        if (typeof iters[ii] === 'string') {
+          set.add(iters[ii]);
+        } else {
+          SetCollection(iters[ii]).forEach(value => set.add(value));
+        }
       }
     });
   }