Skip to content

Commit

Permalink
Merge branch 'main' into 5.x
Browse files Browse the repository at this point in the history
  • Loading branch information
jdeniau committed May 13, 2024
2 parents 8079986 + 493afba commit 5b40220
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 1 deletion.
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,6 +133,16 @@ Map<{ a?: string }>({ a: 'a' }).delete('a'); // you can only delete an optional

For now, only `get`, `getIn`, `set`, `update`, `delete`, `remove`, `toJS`, `toJSON` methods are implemented. All other methods will fallback to the basic `Map` definition. Other method definition will be added later, but as some might be really complex, we prefer the progressive enhancement on the most used functions.

## [4.3.6] - 2024-05-13

- Fix `Repeat(<value>).equals(undefined)` incorrectly returning true [#1994](https://github.com/immutable-js/immutable-js/pull/1994) by [@butchler](https://github.com/butchler)

## [4.3.5] - 2024-01-16

- Upgrade to TS 5.1 [#1972](https://github.com/immutable-js/immutable-js/pull/1972) by [@jdeniau](https://github.com/jdeniau)
- Fix Set.fromKeys types with Map constructor in TS 5.0 [#1971](https://github.com/immutable-js/immutable-js/pull/1971) by [@jdeniau](https://github.com/jdeniau)
- Fix Read the Docs link on readme [#1970](https://github.com/immutable-js/immutable-js/pull/1970) by [@joshding](https://github.com/joshding)

## [4.3.4] - 2023-08-25

- Rollback toJS type due to circular reference error [#1958](https://github.com/immutable-js/immutable-js/pull/1958) by [@jdeniau](https://github.com/jdeniau)
Expand Down
4 changes: 4 additions & 0 deletions __tests__/Repeat.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,8 @@ describe('Repeat', () => {
expect(v.toArray()).toEqual(['wtf', 'wtf', 'wtf']);
expect(v.join()).toEqual('wtf,wtf,wtf');
});

it('does not claim to be equal to undefined', () => {
expect(Repeat(1).equals(undefined)).toEqual(false);
});
});
2 changes: 1 addition & 1 deletion src/Repeat.js
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ export class Repeat extends IndexedSeq {
equals(other) {
return other instanceof Repeat
? is(this._value, other._value)
: deepEqual(other);
: deepEqual(this, other);
}
}

Expand Down

0 comments on commit 5b40220

Please sign in to comment.