Fix ESM exports in package.json. Update microbundle. #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since this package is published as commonjs, es6 files are now published using the mjs extension. Added more explicit file paths in the `exports` field, pointing to a unique declaration file for each bundle. Declaration file is copied using the mts extension so it's explicitly marked as es6. The package now passes the [publint](https://publint.dev/) and [Are the types wrong?](https://arethetypeswrong.github.io/) tests.
fedemp
commented
Oct 11, 2023
| } | ||
| }, | ||
| "sideEffects": false, | ||
| "scripts": { | ||
| "build": "microbundle", | ||
| "build": "microbundle && cp ./dist/index.d.ts ./dist/index.d.mts", |
There was a problem hiding this comment.
Are the types wrong? complains if we use the same index.d.ts file for both import and require cause it's detected a cjs file. 🎭 Masquerading as CJS
cp is not available in Windows, but since this is a development script that won't be run by consumers, I assume it would be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since this package is published as commonjs, es6 files are now published using the mjs extension.
Added more explicit file paths in the
exportsfield, pointing to a unique declaration file for each bundle.Declaration file is copied using the mts extension so it's explicitly marked as es6.
The package now passes the publint and Are the types wrong? tests.