Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stray println #772

Closed
wants to merge 1 commit into from
Closed

Remove stray println #772

wants to merge 1 commit into from

Conversation

colinmarc
Copy link

Looks like this snuck in in #754.

@colinmarc
Copy link
Author

By the way, it would be great to get a new release targeting winit = "0.29". I don't think there's any need to pin the minor revision (0.29.2 currently).

@dbr
Copy link
Contributor

dbr commented May 5, 2024

Thanks for the PR - the stray print was removed in #774, along with variuos dependencies updates

I don't think there's any need to pin the minor revision (0.29.2 currently)

I think the Cargo.toml version syntax is a bit confusing in this case - winit = "0.29.2" specifies 0.29.2 as a minimum version, but 0.29.3 etc can still be picked up. To actually pin it to .2 it would need to say winit = "=0.29.2"

That aside, a new release is definitely overdue! Shall try and get a new release of imgui-rs out soon (hopefully today!)

@dbr dbr closed this May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants