New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating msrv #747

Merged

sanbox-irl merged 2 commits into imgui-rs:main from sanbox-irl:updating-msrv

Sep 18, 2023

Member

sanbox-irl commented Sep 17, 2023

this PR adds a formal MSRV to the repo (there's no reason we shouldn't use one)
bumps that MSRV to 1.70
moves rustfmt's check to run only on main
reduces clippy to only run on stable rust, not on MSRV AND makes it only run on main
reduces testing to ONLY the MSRV because of Rusts forwards compatibility concerns
moves all crates to edition 2021
moves us to formally use resolver = 2 in the workspace setting

sanbox-irl added 2 commits

September 17, 2023 13:53


          basic updating

31ce976


          simplifying testing:

3f5fd2e

- clippy runs on stable
- testing runs on msrv only

sanbox-irl requested a review from dbr

September 17, 2023 18:11

sanbox-irl merged commit 4c80d0d into imgui-rs:main

5 checks passed

sanbox-irl deleted the updating-msrv branch

September 18, 2023 12:52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment