Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gamepad support for winit using gilrs #745

Closed
wants to merge 1 commit into from
Closed

gamepad support for winit using gilrs #745

wants to merge 1 commit into from

Conversation

Calcoph
Copy link

@Calcoph Calcoph commented Sep 10, 2023

Have to use WinitPlatform::handle_controller_event() instead of WinitPlatform::handle_event()

Adds the dependency gilrs to imgui-winit-support

@sanbox-irl
Copy link
Member

hi @Calcoph thanks for the hard work!

However, i feel uncertain about this PR and think it might be best to close it for now. That's because this actually can be entirely handled by users directly rather than baked into this crate -- IMO that's a big win. In fact, i really see your work as having two distinct halves -- an imgui-gilrs crate, which handles imgui + gilrs type glue, and your hook into winit. I'd love to support such an imgui-gilrs crate with a shoutout on the README, but this repository has made many errors by overly directly supporting many third party dependencies. This hasn't been a great idea, so I'm loathe to take on another dependency whose updates we'd need to follow.

@Calcoph
Copy link
Author

Calcoph commented Sep 15, 2023

I like your idea of a separate imgui-gilrs crate, since it doesn't really need any of the private imgui-winit-support code. In order to not put extra pressure onto imgui mantainers, I've decided to make that crate separately. It's here if anyone is interested.

@Calcoph Calcoph closed this Sep 15, 2023
@sanbox-irl
Copy link
Member

Thank you! I'll add a line in the README for this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants