Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require correct version of cc #744

Merged
merged 1 commit into from Sep 15, 2023
Merged

Require correct version of cc #744

merged 1 commit into from Sep 15, 2023

Conversation

SkiFire13
Copy link
Contributor

imgui-sys's build script uses cc::Tool::is_like_gnu and cc::Tool::is_like_clang which were added only in cc 1.0.2. This made the build fail when trying to compile using cargo-minimal-versions.

@SkiFire13 SkiFire13 mentioned this pull request Aug 26, 2023
Open
@sanbox-irl sanbox-irl merged commit 0f65562 into imgui-rs:main Sep 15, 2023
2 of 8 checks passed
@SkiFire13 SkiFire13 deleted the fix-minimal-versions branch September 15, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SkiFire13 @sanbox-irl