Add functions begin_popup_context_*.
#738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodrigorc
force-pushed
the
PopupContext
branch
3 times, most recently
from
dabd2a4
to
c6decca
Compare
|
Hey, thanks for this PR! This looks great -- I'll take a deeper look soon and likely merge! |
sanbox-irl
requested changes
Sep 17, 2023
sanbox-irl
force-pushed
the
PopupContext
branch
from
c6decca
to
53825cf
Compare
|
okay @rodrigorc I added a few extra methods to handle setting a label or not. I agree that handling the non-RMB case should be deferred till we have a user who wants that, since it sounds...awfully niche and annoying. Let me know what you think of these additions and we can merge it! |
sanbox-irl
force-pushed
the
PopupContext
branch
from
f7d9dc4
to
135dcb5
Compare
|
I see the changes all fine, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
In ImGui there are these handy functions to do pop-up menus, usually by right-clicking the mouse. This PR adds basic wrappers around these.
The code is quite self-explanatory. The most notable thing missing is the ability to specify a flag other than
ImGuiPopupFlags_MouseButtonRight. For me, I only open pop-ups when doing aMouseButtonRight, so this is good enough. But if you think it is wort it, we could ad an enum wrapper and a way to specify it, maybe a builder helper struct o a fewbegin_popup_context_*_with_flags()functions.