Disable winit default features

[dzil123]

Allows users to set their own winit features.

Previously the winit default features would have been enabled even if the user disabled it in their own Cargo.toml. This is because of the way Cargo does feature unification.

This modification does not change any functionality because imgui-winit-support does not use winit::platform.

[thomcc]

Thanks, looks good assuming CI is green.

[thomcc]

I don't think I can get this in a release easily soon, since there are a lot of breaking changes and we have a lot more planned (see #462). If you need it badly I could probably backport it and cut a patch release, but probably not until after the weekend.

[dzil123]

Thank you for the patch release offer, but this isn't urgent. I understand v0.8.0 is a big change.

[thomcc]

Ah, it looks like it won't be fully backwards compatible anyway...

[dzil123]

The default features can be re-enabled only during CI with the --features winit-2x/default flag.

I haven't figured out how to do this for the --all-features clippy run.

[thomcc]

Ugh, this pretty much sucks. I'd like to find a better way. Note that among other things, you can pass more than one feature at a time, but is there no way to make --all-features work?

Also, please reflect any changes you make here to https://github.com/imgui-rs/imgui-rs/blob/master/xtask/src/main.rs#L38-L61, which is used for local dev (it's not used for CI too so that we get more insight on which operation in particular failed)

[thomcc]

This will need some updates after #485, sorry.

[dzil123]

How's that? I wasn't sure if I should add winit 0.25 to Github CI and xtask.

[sanbox-irl]

hey @dzil123 looks like we lost the thread on this one here.

I think we're all good to go right? Thom's primary issue was losing -- all-features and you did a trick with a fake feature to take care of that. I think we just need a rebase and then it can merge?

[dzil123]

Thanks for checking in! Yeah, I think this is good to go.

I modified the default features list to include the winit default features as well, to avoid breaking projects that somehow depend on imgui-winit-support but not winit. So to opt out of winit default features in a consumer crate, default-features should be set to false for both imgui-winit-support and winit.

I also added winit 0.25 to Github CI and xtask as I said above.

One thing however is that cargo clippy/test for winit 0.19 is failing on imgui-rs:master, so Github may not allow this to be merged.

[sanbox-irl]

Fixed the winit19 error, rebased this commit to it, and added to the changelog. Thanks so much for the work! This is an area that I am not well equipped, and our winit dependency specifically is a mess, so I appreciate you doing the leg work here. Thank you!