New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor client-hints, add Permissions-Policy #12
Conversation
Permission policy does not seem to work... It doesn't delegate the hints to imageengine. When I removed the permission haeader, and left the feature policy in, it worked. PP seems to be bleeding edge. Good catch though! Was not aware of its inclusion in v88 |
Ah. " missing. |
Nice, thanks for testing that, I have a small update to push that cleans up some code and then I'll test it as well and we can create a new version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR reworks the Client-Hints / CORS-support headers so all code uses the same set of client-hints.
It also implements
Permissions-Policy
, the replacement forFeature-Policy
as of Chrome 88For more info see: