Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript support #48

Closed

Conversation

sbarfurth
Copy link
Collaborator

@sbarfurth sbarfurth commented Jul 20, 2018

Getting started with TypeScript support (issue #28). These are the main types I could identify for the moment. I'm not too well versed with TypeScript declarations, so pull-requests to the branch are welcome.

  • Identify all types
  • Find best location for type declaration file
  • Add type declarations to package.json

@imbrn
Copy link
Owner

imbrn commented Jul 20, 2018

Great!

@sbarfurth
Copy link
Collaborator Author

Should Validation describe every function it exposes, aka. all rules and core functions?

@sbarfurth sbarfurth changed the title Start up TypeScript support TypeScript support Jul 20, 2018
@imbrn
Copy link
Owner

imbrn commented Jul 20, 2018

I don't know it well. I'm not very familiar with TypeScript and how it works. We need some more experienced help.

@sbarfurth sbarfurth force-pushed the improvement/typescript-support branch from 4ffbc95 to 2d30348 Compare July 20, 2018 14:52
@sbarfurth
Copy link
Collaborator Author

Actually these should be published to DefinitelyTyped/DefinitelyTyped as per recommendation in the TypeScript guide. Therefore this PR is not really something to be merged.

@sbarfurth sbarfurth closed this Jul 20, 2018
@sbarfurth sbarfurth deleted the improvement/typescript-support branch July 20, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants