Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GIF with P frame cannot be loaded #1036

Merged
merged 9 commits into from Sep 19, 2023
Merged

Conversation

Pandede
Copy link
Contributor

@Pandede Pandede commented Sep 4, 2023

See #1030

@Pandede
Copy link
Contributor Author

Pandede commented Sep 13, 2023

The test case of ffmpeg is failed but I do not edit anything related to ffmpeg, may you check for the reason? Thank you!

@FirefoxMetzger
Copy link
Contributor

Yes. This failure is related to the release of a new version of imageio-ffmpeg. I will have to look into this during the weekend and then fix it.

@FirefoxMetzger
Copy link
Contributor

I fixed the ffmpeg error on master and merged it into this branch. Now CI should be happy :)

Copy link
Contributor

@FirefoxMetzger FirefoxMetzger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice changes @Pandede ! Sorry for being slow on the uptake on my side.

I started a new job during the summer and I am still working out a routine of how to split my time between work, open source, and life so that each part gets the time it deserves 😅 .

@FirefoxMetzger FirefoxMetzger merged commit f4fc7f5 into imageio:master Sep 19, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants