Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade zune-jpeg #2198

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

fintelia
Copy link
Contributor

@fintelia fintelia commented Apr 8, 2024

Currently targets 0.5.0-rc0, will switch to the full 0.5.0 release once it comes out

@fintelia fintelia marked this pull request as draft April 8, 2024 02:29
@fintelia fintelia mentioned this pull request Apr 16, 2024
@Murad-Awad
Copy link

You need to use ZCursors rather than Cursor from what I can tell, did some testing and when decoding images with your implementation on an all black image and saw gray pixels randomly come up (they may have been new pixels), to look at an example of how I made it work (probably has some unnecessary code): main...Murad-Awad:image:upgrade-zune

@Murad-Awad
Copy link

You need to use ZCursors rather than Cursor from what I can tell, did some testing and when decoding images with your implementation on an all black image and saw gray pixels randomly come up (they may have been new pixels), to look at an example of how I made it work (probably has some unnecessary code): main...Murad-Awad:image:upgrade-zune

I also tested out a version that is functionally the same as yours outside of setting the color + limits params properly (although limits is probably not needed at all given how it is initialized) + using ZCursor: main...Murad-Awad:image:mawad/keep-testing-zune

@fintelia
Copy link
Contributor Author

fintelia commented Apr 17, 2024

@Murad-Awad could you file an issue against the upstream zune-jpeg crate? My understanding is that this version without ZCursor is expected to decode JPEGs properly, so if you are seeing some that get corrupted, they'll want to know

@Murad-Awad
Copy link

will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants