Improve encode_gray performance in BmpEncoder #2193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you share any benchmarks results you've measured from these changes? |
|
The former is a benchmark for encoding BMP files before the change, and the latter is the benchmark after the change.
|
fintelia
reviewed
Apr 8, 2024
src/codecs/bmp/encoder.rs
Outdated
| // alpha is never written as it's not widely supported | ||
|
|
||
| // color value is equal to the palette index | ||
| if bytes_per_pixel == 1 { |
There was a problem hiding this comment.
Could you make this x_stride == 1?
src/codecs/bmp/encoder.rs
Outdated
| } | ||
| // alpha is never written as it's not widely supported |
There was a problem hiding this comment.
Could you move this comment into the else branch?
src/codecs/bmp/encoder.rs
Outdated
| // improve performance by writing the whole row at once | ||
| let row_end = row_start + y_stride; | ||
| self.writer | ||
| .write_all(&image[row_start as usize..row_end as usize])?; |
There was a problem hiding this comment.
Mostly comes down to style, but I think this would be slightly nicer as .write_all(&image[row_start as usize..][..y_stride as usize]
|
@fintelia |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
image-rsteam,This Pull Request focuses on enhancing the performance of the encode_gray function within BmpEncoder.
It optimizes the buffer writing process, thereby improving the overall execution speed of the function.
This modification has significantly improved the encoding speed for large-resolution BMP files.