Small improvement: Adjust error messages. #2172
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Landay7
changed the title
fintelia
reviewed
Apr 1, 2024
src/codecs/ico/decoder.rs
Outdated
| DecoderError::PngShorterThanHeader => { | ||
| f.write_str("Entry specified a length that is shorter than PNG header!") | ||
| DecoderError::IcoEntryTooManyPlanesOrHotspot(num_color_planes) => { | ||
| f.write_fmt(format_args!("ICO image entry specifies {}, which exceeds the allowed number of color planes or has an invalid hotspot value", num_color_planes)) |
There was a problem hiding this comment.
This message is unclear whether the number indicated is how many planes are in the image, or how many hotspots are
There was a problem hiding this comment.
Thank you.
I tried to improve it.
Now users at least can know, depending on which file he or she works on.
|
I'm not very familiar with ICO files. Is there a reason we can't say whether the field is a color planes count or a hotspots count? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you for your project.
I use it to work with ico files and sometimes error messages don't provide me with full information, which can help.
So, I tried to improve it a bit and add additional information.
I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to choose either at their option.