Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix <flat::View(Mut) as GenericImageView>::bounds implementations #2032

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix <flat::View(Mut) as GenericImageView>::bounds implementations #2032

wants to merge 3 commits into from

Conversation

zetanumbers
Copy link

flat::View(Mut) have incorrect implementations of GenericImageView::bounds, given that it should return (x, y, w, h), which i inferred from GenericImageView::view's parameters.

@fintelia
Copy link
Contributor

I think it might be better just to deprecate GenericImageView::bounds given that it has inconsistent implementations. That would give a clear warning to anyone currently relying on it, without potentially breaking anyone depending on the current behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zetanumbers @fintelia