Basic serde support #1903
Open
Basic serde support #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a reason that this cannot use Serde derives? Do the non-exhaustive annotations cause issues or something? |
cycraig
reviewed
Apr 28, 2023
Comment on lines
+92
to
+93
| # Enable serde for dependent crates. | ||
| serde = ["dep:serde", "rgb/serde", "num-complex/serde", "num-rational/serde"] |
There was a problem hiding this comment.
Use rgb?/serde to avoid pulling in the optional rgb dependency unintentionally.
Coincidentally, rgb?/serde is the official example for optional dependency features.
(I am not a maintainer)
|
It would indeed be useful to have serde support for ImageBuffer as well, for example, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Releated: #1381
License
I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to choose either at their option.