Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes and release notes for 0.24.5 #1819

Merged

Conversation

micahsnyder
Copy link
Contributor

I hope this isn't too forward. I am eager to get panic fixes in the tiff and jpeg crates, as well as the unpublished fixes in this crate.

Based on these lines in CHANGES.md, I bumped the minor/patch version instead of the major version:

image/CHANGES.md

Lines 75 to 76 in d026f70

- Minimum Rust version is now `1.56` and may change in minor versions until
further notice. It is now tracked in the library's `Cargo.toml`, instead, by

So, 0.24.5 instead of 0.25.0.

Also increase the version requirement for

  • tiff to 0.8.0
  • jpeg to 0.3.0

I believe I may be a first time contributor for this crate and from my personal email/computer, so:

I license past and future contributions under the dual MIT/Apache-2.0 license,
allowing licensees to choose either at their option.

Copy link
Member

@HeroicKatora HeroicKatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this isn't too forward.

Not at all, thanks for drafting them.

It seems like jpeg had some incompatible changes in this version bump, that would be nicer to review as a separate preceeding PR.

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@micahsnyder
Copy link
Contributor Author

It seems like jpeg had some incompatible changes in this version bump, that would be nicer to review as a separate preceeding PR.

Roger. I removed the version bump for jpeg from this PR and created: #1821

Copy link
Member

@HeroicKatora HeroicKatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text LGTM. I'll rebease this and release once #1821 is through CI.

Also increase the version requirement for `tiff` to 0.8.0
@HeroicKatora HeroicKatora merged commit 127a55e into image-rs:master Nov 11, 2022
@HeroicKatora
Copy link
Member

Thanks again for drafting the notes!

@micahsnyder
Copy link
Contributor Author

Thanks again for drafting the notes!

You're welcome. I'm glad I could be of help. Thank you for the quick review and merge.

@micahsnyder micahsnyder deleted the bump-jpeg-tiff-dependencies branch November 12, 2022 23:24
@micahsnyder
Copy link
Contributor Author

Sorry I missed the dev-dependencies version number. Glad you caught it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants