Image Encoder: write with progress #1695
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uch as progress bars in a safe way)
fintelia
reviewed
Apr 23, 2022
| @@ -259,12 +259,12 @@ impl<W: Write> FarbfeldEncoder<W> { | |||
|
|
|||
| /// Encodes the image ```data``` (native endian) | |||
| /// that has dimensions ```width``` and ```height``` | |||
| pub fn encode(self, data: &[u8], width: u32, height: u32) -> ImageResult<()> { | |||
| self.encode_impl(data, width, height)?; | |||
| pub fn encode<F: FnMut(Progress)>(self, data: &[u8], width: u32, height: u32, progress: F) -> ImageResult<()> { | |||
There was a problem hiding this comment.
Isn't this an API breaking change?
There was a problem hiding this comment.
Sure seems like it. We could rewrite this part such that only new methods are added and none of the existing are modified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1488
Note: For backwards compatibility, unlike the reader, the writer adds a default implementation for
write_with_progress, instead of implementingwritein terms ofwrite_with_progress. This way, we can add progress tracking to the individual image writers one by one.On the other hand, not implementing it now might result in it never being implemented