Extended WebP image decoding #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
February 12, 2022 11:57
Doesn't compile, need to restructure some parts.
Only works with VP8L animated at the moment.
Also improves the structures in extended to match the possible values better.
Note gif doesn't support transparency fully so won't encode very well.
Bit awkward that canvas size is u24 but lossless image size is u14.
Removes old tests for previous vp8x behaviour. Adds new tests for alpha/animated
This comment was marked as resolved.
This comment was marked as resolved.
HeroicKatora
requested changes
Mar 9, 2022
added 2 commits
March 10, 2022 19:22
Also updated lib.rs and fixed some number conversion issues.
|
Also, with the tests I created an animated image to test but I couldn't figure out how the reference tests check against the frames of animated images if at all. At the moment, it just checks against the first frame of the animation but ideally it would check more. |
|
@HeroicKatora Sorry, but do you have any further feedback? |
|
All files had been marked 'viewed' for me, somehow must have missed pressing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for decoding of extended WebP headers(VP8X) as described here, including lossy alpha images and animated WebP files.
Integrates with the current AnimationDecoder trait for animation. One thing that I think would make sense on that trait is a way to get the loop count out of it. Also when testing, I was trying the frame offsets in the Frame::from_parts() which fit what I was doing quite well, but it never seemed to work properly when encoded to a GIF, so it just manually draws the background with the offset.
Ignores ICCP colour profiles, XMP and EXIF metadata. If #1448 happens, maybe we could integrate that in.
Feedback would be appreciated.